Severe pain from neck into shoulder dull ache down right arm for 8 weeks now getting pins and needles in right hand is this a trapped nerve?

Probably: Sounds like a cervical radiculopathy which can be a nerve impinged in the neck area related to herniated disc or arthritis. Less likely a more peripheral nerve impingement.

Yes, pinched nerve: Yes, sounds like a classic pinched nerve aka radiculopathy. It will usually resolve on its own, but mechanical cervical traction in physical therapy can help greatly. If pain is severe and/or disabling, then a cervical epidural steroid injection would help.

Yes!: A good visualization of the cervical spine is mandatory ( xray, mri). If negative differential diagnosis with thoracic outlet syndrome is a must!

Need exam: Difficult to determine without an examination. Differential diagnosis could be cervical radiculopathy (pinched nerve in neck), brachial plexopathy, peripheral nerve entrapment such as carpal tunnel syndrome (not uncommon for cts pain to travel up the arm), or even myofascial pain with trigger points. Would suggest physiatric evaluation for definitive diagnosis and treatment.