Shoulder pain whenever i throw a softbal or do repetitive motions like shoveling snow. has been going on for about 7yrs now. i was told impingment?

See shoulder special: You need to consult a shoulder specialist before more damages occur to your shoulder. It is more likely a rotator cuff problem .

Consider treatment: Impingement syndrome occurs when bone spurs originating from the acromion or acromio-clavicular joint grow down and impinge on the rotator cuff. There are many good treatment options available, consider being seen to discuss your options.