Are all lesions on vocal chords cancerous? yes i'm a smoker. thanks'

No: Vocal cord polyps or nodules can be benign, which can arise from chronic vocal use (singer, etc), acid reflux, or smoking or other chronic irritant exposure. Of course, smoking is a big risk for cancer including vocal cord cancer. If persist hoarseness, you should be evaluated by ENT specialist.

Vocal cord lesion.: Not all vocal cord lesions are cancerous, but the likelihood of cancer in this context would be greater in a smoker. Get this evaluated properly, including direct visualization and biopsy.