Have a hacking cough. do i take an expectorant or suppresant?

Depends....: If you have a cough due to an infection, as in acute bronchitis, then an expectorant would be recommended so you could cough out the infected sputum. If there is no infection present, like an allergy related cough, then a suppressant may be helpful. If you are unsure, see your doctor so it can be determined whether there is infection present.