Had a spinal tap last night after three attempts it finally went in through my herniated discs how long is it supposed to hurt? Days weeks longer?

A few days. For most patients, the discomfort after a lumbar puncture resolves in a few days.
It depends. But should be matter of a few days. Remember everyone recover at different rates, there is a normal distribution of recovery. And everyone has different thresholds for pain. So if 10 different individuals accidentally have the same cut across their leg as they shave, how long the discomfort lasts will vary from person to person. So no worries, it should not be long lasting.