If a smoker quits smoking, could their vocal chords heal?

Possibly. Smoking causes changes to the larynx (voice box), some of which are reversible and some that are not. If you have changes to your vocal cords from smoking, you should be followed by an ENT doctor as some changes can turn into cancer.