I'm 18 and suck my thumb & sleep with a teddy bear. Is this considered childish still?

I would ask why. You feel the need to . These are classic "transitional objects" that help children to feel more secure. I would have thought one would have grown out of this stage long before age 18 years old. Ask what need it is filling? Find another way to fill that need.