What age is best for sperm donors?

Reproductive years. It will be best during reproductive years, such as 20 to 50, but obviously man may have viable sperm outside this range. It is more important to consider a person's history and risk for infertility.
18 - 40 years. Almost any age, providing donor is healthy.